-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-8368] Avoid libprotobuf-generated exception when importing apache_beam #9768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for testing this and writing a fix @kamilwu :)
sdks/python/setup.py
Outdated
@@ -119,7 +119,9 @@ def get_version(): | |||
'oauth2client>=2.0.1,<4', | |||
'protobuf>=3.5.0.post1,<4', | |||
# [BEAM-6287] pyarrow is not supported on Windows for Python 2 | |||
('pyarrow>=0.11.1,<0.15.0; python_version >= "3.0" or ' | |||
# [BEAM-8368] pyarrow>=0.14.0 triggers an exception when importing | |||
# apache_beam on macOS 10.15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind filing a jira with arrow and referencing it here? It looks like arrow is considering an 0.15.1 release so maybe this could be resolved there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, jira is filled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dfee50b
to
383f7cd
Compare
Run Python PreCommit |
@aaltay should we go ahead and merge this prior to the 2.17.0 cut? We can update it if arrow 0.15.1 is out in time. |
Yes, thank you. Is arrow 0.15.1 fixing this issue? |
Yeah the fix for ARROW-6860 should be in 0.15.1, and it sounds like that will resolve our issue. |
Great, thank you! |
Thanks! |
This is a workaround to an error that occurs when importing apache_beam on macOS 10.15 Catalina.
For more information, refer to a JIRA discussion: https://issues.apache.org/jira/browse/BEAM-8368
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.